plugins/platforms/virtual/virt_output.cpp
1 ↗	(On Diff #29599)	same here, please call it virtual_output.cpp
plugins/platforms/virtual/virt_output.h
1 ↗	(On Diff #29599)	please name this file virtual_output.h as your class is called VirtualOutput and the include guard is called KWIN_VIRTUAL_OUTPUT_H. virt_output reminds me too much of libvirt and who knows maybe we need to add code for libvirt integration in future.
plugins/platforms/virtual/virtual_backend.h
68–85	please move the implementation into the cpp file

This revision now requires changes to proceed.Mar 17 2018, 11:20 AM

Rename virt_output files to virtual_output
setVirtualOutputs implementation in cpp
rebase on master

romangg marked 3 inline comments as done.Mar 19 2018, 11:10 AM

graesslin accepted this revision.Mar 19 2018, 4:16 PM

This revision is now accepted and ready to land.Mar 19 2018, 4:16 PM

Closed by commit R108:8136c2722bea: [platforms/virtual] Add virtual output class (authored by romangg). · Explain WhyMar 19 2018, 9:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/integration/activities_test.cpp (2 lines)
M			autotests/integration/colorcorrect_nightcolor_test.cpp (2 lines)
M			autotests/integration/debug_console_test.cpp (2 lines)
M			autotests/integration/decoration_input_test.cpp (2 lines)
M			autotests/integration/desktop_window_x11_test.cpp (2 lines)
M			autotests/integration/dont_crash_aurorae_destroy_deco.cpp (2 lines)
M			autotests/integration/dont_crash_empty_deco.cpp (2 lines)
M			autotests/integration/dont_crash_no_border.cpp (2 lines)
M			autotests/integration/dont_crash_useractions_menu.cpp (2 lines)
M			autotests/integration/input_stacking_order.cpp (2 lines)
M			autotests/integration/internal_window.cpp (2 lines)
M			autotests/integration/lockscreen.cpp (2 lines)
M			autotests/integration/maximize_test.cpp (2 lines)
M			autotests/integration/plasma_surface_test.cpp (3 lines)
M			autotests/integration/plasmawindow_test.cpp (2 lines)
M			autotests/integration/pointer_constraints_test.cpp (2 lines)
M			autotests/integration/pointer_input.cpp (5 lines)
M			autotests/integration/quick_tiling_test.cpp (2 lines)
M			autotests/integration/screen_changes_test.cpp (6 lines)
M			autotests/integration/screenedge_client_show_test.cpp (2 lines)
M			autotests/integration/shade_test.cpp (2 lines)
M			autotests/integration/shell_client_rules_test.cpp (2 lines)
M			autotests/integration/shell_client_test.cpp (2 lines)
M			autotests/integration/struts_test.cpp (11 lines)
M			autotests/integration/touch_input_test.cpp (2 lines)
M			autotests/integration/transient_placement.cpp (2 lines)
M			autotests/integration/window_rules_test.cpp (2 lines)
M			autotests/integration/window_selection_test.cpp (2 lines)
M			autotests/integration/xclipboardsync_test.cpp (2 lines)
M			autotests/integration/xwayland_input_test.cpp (2 lines)
M			plugins/platforms/virtual/CMakeLists.txt (1 line)
P			plugins/platforms/virtual/screens_virtual.h (1 line) Copied to multiple locations: plugins/platforms/virtual/virtual_output.cpp plugins/platforms/virtual/virtual_output.h
M			plugins/platforms/virtual/screens_virtual.cpp (30 lines)
M			plugins/platforms/virtual/virtual_backend.h (36 lines)
M			plugins/platforms/virtual/virtual_backend.cpp (40 lines)
P			plugins/platforms/virtual/virtual_output.h (39 lines) Copied from plugins/platforms/virtual/screens_virtual.h
P			plugins/platforms/virtual/virtual_output.cpp (38 lines) Copied from plugins/platforms/virtual/screens_virtual.h

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	29591	4a3104b		Mar 15 2018, 12:09 PM	★	★
Diff 2	29599	4a3104b	- Fix dummy output creation	Mar 15 2018, 2:24 PM	★	★
Diff 3	29902	d3aa33b	- Rename virt_output files to virtual_output	Mar 19 2018, 11:07 AM	★	★
Diff 4	29948	d3aa33b	R108:8136c2722bea31e284af7865b107b99fc179aef3	Mar 19 2018, 9:12 PM	★	★