Details

Reviewers

rizzitello
patrickelectric
tcanabrava

Commits

R231:41a8c1a86a16: Reestructure the creation of the sidebar
R231:13eee93a24ae: Add Itens on the View again
R231:c86dcfc61a93: [UI REESTRUCTURE] Start the Sidebar Layout
R231:133b1a9e79e6: Remove commented code - Fix small things around
R231:87629160f10d: Fix style issues
R231:1891883e8b53: Re-enable the whole gui
R231:5ad3a70c709a: Use Icons

Summary

Add Itens on the View again

Re-enable the whole gui

Reestructure the creation of the sidebar

Remove commented code - Fix small things around

Fix variable names

Use Icons

We need new icons

Fix style issues

Signed-off-by: Lays Rodrigues <laysrodriguessilva@gmail.com>

Diff Detail

Repository

R231 Atelier

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

laysrodrigues requested review of this revision.Mar 15 2018, 2:39 AM

laysrodrigues created this revision.

laysrodrigues retitled this revision from Reestructure of Ui and small fixes [UI REESTRUCTURE] Start the Sidebar Layout to Part5 Reestructure of Ui and small fixes.Mar 15 2018, 2:41 AM

rizzitello requested changes to this revision.Mar 15 2018, 4:06 AM

rizzitello added inline comments.

src/mainwindow.cpp
19	New Empty line
src/mainwindow.ui
9–10	manually set these back

This revision now requires changes to proceed.Mar 15 2018, 4:06 AM

patrickelectric requested changes to this revision.Mar 15 2018, 12:48 PM

patrickelectric added inline comments.

src/mainwindow.h
46	Why this template is necessary ?
src/mainwindow.ui
11	This both should be zero no ?

laysrodrigues added inline comments.Mar 15 2018, 9:30 PM

src/mainwindow.h
46	@tcanabrava Can you address this? Its your code xD (Now I'm sure xD)

tcanabrava added inline comments.Mar 16 2018, 12:58 PM

src/mainwindow.h
46	it passes the type to the qobject_cast so I don't need to write qobject_cast<Blah>(m_map[s].second); every time, just .get<Blah>(s);

patrickelectric added inline comments.Mar 16 2018, 1:01 PM

src/mainwindow.h
30	#include <QMainWindow> #include <QToolButton> Thy this is necessary ?
46	And where do you use the get function ? I can't find in this patch.

laysrodrigues added inline comments.Mar 16 2018, 3:11 PM

src/mainwindow.cpp
151	@patrickelectric he is using here

patrickelectric added inline comments.Mar 16 2018, 3:47 PM

src/mainwindow.h
46	Ok, sorry for that.

Remove unused headers and remove empty line

Remove empty line

rizzitello accepted this revision.Mar 17 2018, 1:42 AM

patrickelectric requested changes to this revision.Mar 17 2018, 1:28 PM

patrickelectric added inline comments.

src/mainwindow.cpp
35	Alphabetic order.
36	Where this is used ?
40	Alphabetic order.

This revision now requires changes to proceed.Mar 17 2018, 1:28 PM

laysrodrigues planned changes to this revision.Mar 17 2018, 1:51 PM

laysrodrigues marked 3 inline comments as done.

laysrodrigues added inline comments.

src/mainwindow.cpp
36	removed.

Patrick fixes

patrickelectric requested changes to this revision.Mar 17 2018, 1:53 PM

patrickelectric added inline comments.

src/mainwindow.cpp
35	S goes before T.

This revision now requires changes to proceed.Mar 17 2018, 1:53 PM

laysrodrigues marked an inline comment as done.Mar 17 2018, 1:55 PM

S before T

patrickelectric accepted this revision.Mar 17 2018, 2:19 PM

This revision is now accepted and ready to land.Mar 17 2018, 2:19 PM

Closed by commit R231:c86dcfc61a93: [UI REESTRUCTURE] Start the Sidebar Layout (authored by tcanabrava, committed by Lays Rodrigues <laysrodriguessilva@gmail.com>). · Explain WhyMar 17 2018, 2:35 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/mainwindow.h (22 lines)
M			src/mainwindow.cpp (63 lines)
M			src/mainwindow.ui (152 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	29557	eb2b969		Mar 15 2018, 2:39 AM	★	★
Diff 2	29720	eb2b969	Remove unused headers and remove empty line	Mar 17 2018, 1:21 AM	★	★
Diff 3	29722	eb2b969	Remove empty line	Mar 17 2018, 1:33 AM	★	★
Diff 4	29751	eb2b969	Patrick fixes	Mar 17 2018, 1:51 PM	★	★
Diff 5	29752	eb2b969	S before T	Mar 17 2018, 1:56 PM	★	★
Diff 6	29754	eb2b969	R231:c86dcfc61a938bcaaa240da4db80a1df1395d3a4	Mar 15 2018, 2:33 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
87629160f10d	26a86efcc625	5ad3a70c709a	Lays Rodrigues	Fix style issues (Show More…)	Mar 15 2018, 2:22 AM
5ad3a70c709a	9c3bb1dc1df9	133b1a9e79e6	Tomaz Canabrava	Use Icons (Show More…)	Feb 10 2018, 2:33 PM
133b1a9e79e6	b0e897744c9f	41a8c1a86a16	Tomaz Canabrava	Remove commented code - Fix small things around (Show More…)	Feb 10 2018, 2:05 PM
41a8c1a86a16	081939a82a74	1891883e8b53	Tomaz Canabrava	Reestructure the creation of the sidebar	Feb 10 2018, 2:04 PM
1891883e8b53	5a0702bd30da	13eee93a24ae	Tomaz Canabrava	Re-enable the whole gui	Feb 10 2018, 1:40 PM
13eee93a24ae	ebdbe8826fe8	c86dcfc61a93	Tomaz Canabrava	Add Itens on the View again	Feb 10 2018, 1:06 PM
c86dcfc61a93	927c7109b70f	eb2b969eeb64	Tomaz Canabrava	[UI REESTRUCTURE] Start the Sidebar Layout	Feb 10 2018, 12:49 PM

Part5 Reestructure of Ui and small fixes
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 29754

src/mainwindow.h

src/mainwindow.cpp

src/mainwindow.ui

Part5 Reestructure of Ui and small fixesClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 29754

src/mainwindow.h

src/mainwindow.cpp

src/mainwindow.ui

Part5 Reestructure of Ui and small fixes
ClosedPublic
Actions

Revision Contents
Changeset List