Fix Favorites being clickable on composite op drop down
ClosedPublic

Authored by scottpetrovic on Mar 14 2018, 11:31 PM.

Details

Reviewers
rempt
Group Reviewers
Krita
Summary

There was a previous fix that had to do with the brush editor settings. That fixed caused the layer blending mode options to not have its favorite checkbox clickable.

They share the same control so that was the reason. This patch should fix that by re-adding the hack that was done to override and force new events.

Test Plan

I tested the following areas:

  1. Brush settings and changing an area doesn't make the brush preset dirty
  2. Checked the blending mode area in the brush settings to make sure you could change the blending mode and add/remove favorites
  3. Checked the paintopbox painting blending mode. Select different blend modes and add/remove favorites
  4. Checked the layer docker blending mode drop down. Select different blend modes and add/remove favorites.

It all appears to work ok after this path.

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
scottpetrovic requested review of this revision.Mar 14 2018, 11:31 PM
scottpetrovic created this revision.
rempt accepted this revision.Mar 15 2018, 8:23 AM

Yes, this works for me. And it's good to have the explicit documentation about the hack in the source code.

This revision is now accepted and ready to land.Mar 15 2018, 8:23 AM

This is pushed out to master and the 4.0 branch