Summary: Properly emit dataChanged signals when a file changes. dataChanged() was only emitted sometimes and then only for column 0.
ClosedPublic
Actions

Authored by chehrlic on Mar 14 2018, 7:31 PM.

Details

Reviewers

dfaure
aspotashev
broulik

Commits

R220:7d1a5218b535: Summary: Properly emit dataChanged signals when a file changes. dataChanged()…

Test Plan

Open kdesvn, externally modify a file or do a svn revert. The item immediately
changes it's color. Before the change the color only changed when the item
was redrawn (e.g. when the focus changed).
It still is not updated correctly in the dirview. Needs some more investigation.

Diff Detail

Repository

R220 Subversion Client (KDE SVN)

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

chehrlic requested review of this revision.Mar 14 2018, 7:31 PM

chehrlic created this revision.

chehrlic added reviewers: dfaure, aspotashev, broulik.Mar 14 2018, 7:33 PM

dfaure added inline comments.Mar 15 2018, 3:18 PM

src/svnfrontend/models/svnitemmodel.cpp
613	should this only happen under an if(ret) ?

This revision was not accepted when it landed; it landed in state Needs Review.Mar 30 2018, 7:13 PM

Closed by commit R220:7d1a5218b535: Summary: Properly emit dataChanged signals when a file changes. dataChanged()… (authored by chehrlic). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/svnfrontend/maintreewidget.h (2 lines)
M			src/svnfrontend/maintreewidget.cpp (10 lines)
M			src/svnfrontend/models/svnitemmodel.h (3 lines)
M			src/svnfrontend/models/svnitemmodel.cpp (15 lines)
M			src/svnfrontend/svnactions.h (2 lines)
M			src/svnfrontend/svnactions.cpp (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	29523	fc32082		Mar 14 2018, 7:31 PM	★	★
Diff 2	30964	59c1b2c	R220:7d1a5218b535ca04d5667bd65e66643f6ae59706	Mar 30 2018, 7:13 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
4f67104cba48	76a339ace6a1	fc3208214869	Christian Ehrlicher	Summary: Properly emit dataChanged signals when a file changes. dataChanged()… (Show More…)	Mar 14 2018, 7:25 PM