Swap position and size in crop tool
ClosedPublic

Authored by tsokar on Mar 14 2018, 1:27 PM.

Details

Summary

When one wants to re-use crop settings in gwenview (i.e. position and size), they have to be entered in the following order :
1/ Size
2/ Position

(it is not possible to do it the other way, as position is locked until the size of the crop area is smaller than the size of the image).

However, the settings are displayed in the reverse order, which is not convenient (un-necessary mouse actions).

BUG: 391758

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tsokar requested review of this revision.Mar 14 2018, 1:27 PM
tsokar created this revision.


(images comparing before and after)

rkflx accepted this revision.Mar 14 2018, 2:54 PM
rkflx added a subscriber: rkflx.

Perfect. I'll leave it open for a day or two to give others a chance to comment. In case there are no objections, I'll land the patch on your behalf.

BTW, if you are interested in contributing more to Gwenview or other parts of KDE, feel free to ask for help or let us know if you need ideas for what to work on. There are plenty of smaller things to fix, as well as more challenging tasks ;)

(For example, I'd love to be able to press F10 to create a new folder, the Crop bar is cut off in Advanced mode for narrow windows, etc.)

This revision is now accepted and ready to land.Mar 14 2018, 2:54 PM

Looks good to me too, and works great!

Simple change - but feels more convenient this way. ๐Ÿ‘

This revision was automatically updated to reflect the committed changes.