Differential D11327

[Workspace Options KCM] sync() after writing settings
ClosedPublic
Actions

Authored by broulik on Mar 14 2018, 12:25 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R119:06c837e274ed: [Workspace Options KCM] sync() after writing settings
Summary

Ensures changes take effect immediately

Test Plan

Something must have changed in KConfig or so since I've seen the same pattern in various other KCMs lately (e.g. looandfeel)

  • Verified that changing tooltip settings now enables/disables tooltip immediately

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 14 2018, 12:25 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 14 2018, 12:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Mar 14 2018, 12:25 PM
davidedmundson accepted this revision.Mar 14 2018, 1:27 PM
davidedmundson added a subscriber: davidedmundson.

Something must have changed in KConfig or so since I've seen the same pattern in various other KCMs lately (e.g. looandfeel)

I think you're identifying non-issues.
Unless someone else has a plasmarc open that kconfig goes out of scope, the destructor syncs which is why it's never been a problem.

This revision is now accepted and ready to land.Mar 14 2018, 1:27 PM
Closed by commit R119:06c837e274ed: [Workspace Options KCM] sync() after writing settings (authored by broulik). · Explain WhyMar 15 2018, 12:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 29588

View Options

kcms/workspaceoptions/workspaceoptions.cpp

Loading...