Add Qt5KeyChain support to store the password
ClosedPublic
Actions

Authored by dfaure on Mar 14 2018, 11:36 AM.

Details

Reviewers

mlaurent

Commits

Test Plan

No need to type the password when starting ruqola, anymore.

Repository

R865 Ruqola

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

dfaure requested review of this revision.Mar 14 2018, 11:36 AM

dfaure created this revision.

Fill in the password field after logout

mlaurent requested changes to this revision.Mar 14 2018, 7:03 PM

mlaurent added inline comments.

CMakeLists.txt
54	Required finally ? So for the future we need to be sure that CI has this lib but ok
src/rocketchataccountsettings.cpp
68	Remove commented code
137	Remove it
src/rocketchataccountsettings.h
28	Coding style namespace QKeychain { class Job; }
67	not necessary as we use new connect api. move it on private area

This revision now requires changes to proceed.Mar 14 2018, 7:03 PM

Make it optional; add slot in case of errors when writing.

Fix it and commit :)
Thanks.

src/rocketchataccountsettings.cpp
32	move the using namespace before the #endif

This revision is now accepted and ready to land.Mar 15 2018, 12:51 PM

anthonyfieroni added inline comments.

src/CMakeLists.txt
136	This sould not present here, it's on line 144 when it should :)

made both requested fixes

			Path	Packages
M			CMakeLists.txt (12 lines)
M			autotests/rocketchataccountsettingstest.cpp (2 lines)
M			config-ruqola.h.cmake (2 lines)
M			src/CMakeLists.txt (6 lines)
M			src/qml/LoginPage.qml (1 line)
M			src/rocketchataccount.h (7 lines)
M			src/rocketchataccount.cpp (16 lines)
M			src/rocketchataccountsettings.h (12 lines)
M			src/rocketchataccountsettings.cpp (62 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	29488	641afe5		Mar 14 2018, 11:36 AM	★	★
Diff 2	29498	641afe5	Fill in the password field after logout	Mar 14 2018, 1:13 PM	★	★
Diff 3	29579	4f4a904	Make it optional; add slot in case of errors when writing.	Mar 15 2018, 10:34 AM	★	★
Diff 4	29601	4f4a904	made both requested fixes	Mar 15 2018, 2:38 PM	★	★