Differential D11293

Use Cancel button by default when closing Dolphin with multiple tabs
AbandonedPublic
Actions

Authored by rominf on Mar 13 2018, 5:47 PM.

Details

Reviewers
None
Group Reviewers
Dolphin
Summary
  1. Open multiple tabs in Dolphin
  2. Close it
  3. Observe that Quit button is default which is not good because the user can close multiple tabs accidently

This patch fixes this. Now Cancel is the default button.

Test Plan
  1. Open multiple tabs in Dolphin
  2. Close it
  3. Observe that Cancel button is default

Diff Detail

Repository
R318 Dolphin
Branch
close-multiple-tabs-cancel
Lint
No Linters Available
Unit
No Unit Test Coverage
rominf requested review of this revision.Mar 13 2018, 5:47 PM
rominf created this revision.
ngraham added a subscriber: ngraham.Mar 13 2018, 5:49 PM

Thanks, will test later today!

rominf updated this revision to Diff 29424.Mar 13 2018, 5:58 PM
  • Remove unused line
ngraham added a comment.Mar 13 2018, 11:13 PM

I'm sorry for jerking you around, but it seems that our conclusion in D10960 is that the Cancel button does not need to be made the default here, since closing multiple tabs isn't really destructive enough to warrant that. So this patch is not needed. Thanks anyway, and I appreciate your attention to detail!

rominf abandoned this revision.Mar 14 2018, 6:34 AM

@ngraham OK, no problem.

Revision Contents
Changeset List

PathPackages
Msrc/dolphinmainwindow.cpp (4 lines)

Diff 29422

View Options

src/dolphinmainwindow.cpp

Loading...