BUG : 365420
Details
Details
Diff Detail
Diff Detail
- Repository
- R32 KDevelop
- Lint
Lint Skipped - Unit
Unit Tests Skipped
plugins/clang/codegen/adaptsignatureassistant.cpp | ||
---|---|---|
59 ↗ | (On Diff #29420) | Only need to lock here, no? Or at least after the if. |
Comment Actions
Looks good to me, thanks!
plugins/clang/codegen/adaptsignatureassistant.cpp | ||
---|---|---|
59 ↗ | (On Diff #29420) | Yeah but the macro is not a lock, just an assert. If you expect the function to be called with the lock, it IMO makes sense to put it on the top. |
plugins/clang/codegen/adaptsignatureassistant.cpp | ||
---|---|---|
49 ↗ | (On Diff #29420) | afaik you can simplify the below by reusing a function from DUChainUtils that gets you the declaration for a definition. always cast that at the start and then cast the return result |
53 ↗ | (On Diff #29420) | here and below: space after keywords (if (...) |
plugins/clang/codegen/adaptsignatureassistant.cpp | ||
---|---|---|
49 ↗ | (On Diff #29420) | bool isConstructor(const Declaration *functionDecl) { auto classFun = dynamic_cast<const ClassFunctionDeclaration*>(DUChainUtils::declarationForDefinition(functionDecl)); return classFun && classFun->isConstructor(); } |