Remove obsolete variable LIBALKIMIA_INCLUDE_DIR from alkimia package config file
ClosedPublic

Authored by habacker on Mar 13 2018, 2:19 PM.

Details

Summary

In the past alkimia clients needed to use LIBALKIMIA_INCLUDE_DIR for
adding alkimia include pathes. Upgrading to 7.0 makes this obsolete,
because the alkimia package provides an imported cmake target named
'Alkimia::alkimia' which includes the location of alkimia
headers. See README.md for more informations how to use this library.

Test Plan

compiled on linux

Diff Detail

Repository
R471 Alkimia Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
habacker requested review of this revision.Mar 13 2018, 2:19 PM
habacker created this revision.

Unless I am doing something completely wrong here, it fails for me:

[  4%] Building CXX object kmymoney/mymoney/storage/CMakeFiles/kmm_storage.dir/mymoneystoragexml.cpp.o
In file included from /home/thb/devel/kmymoney/kmymoney/mymoney/storage/mymoneystoragexml.cpp:46:
/home/thb/devel/kmymoney/kmymoney/mymoney/mymoneysecurity.h:40:10: fatal error: 
      'alkimia/alkvalue.h' file not found
#include <alkimia/alkvalue.h>
         ^
1 error generated.

Looks like stuff gets installed in a very weird place:

% ls /usr/include/alkimia/Qt5/alkimia
alkcompany.h  alk_export.h  alkquoteitem.h  alkvalue.h

Unless I am doing something completely wrong here, it fails for me:

[  4%] Building CXX object kmymoney/mymoney/storage/CMakeFiles/kmm_storage.dir/mymoneystoragexml.cpp.o
In file included from /home/thb/devel/kmymoney/kmymoney/mymoney/storage/mymoneystoragexml.cpp:46:
/home/thb/devel/kmymoney/kmymoney/mymoney/mymoneysecurity.h:40:10: fatal error: 
      'alkimia/alkvalue.h' file not found
#include <alkimia/alkvalue.h>
         ^
1 error generated.

I guess that the target you are currently compiling does not link to Alkimia::alkimia, see README.md in alkimia source dir.
It has gotten the below mentioned alkimia include location from the LIBALKIMIA_INCLUDE_DIR before.
In general every target which did depend on LIBALKIMIA_INCLUDE_DIR now needs to add Alkimia::alkimia to the target_link_libraries for the related target.

Looks like stuff gets installed in a very weird place:
  % ls /usr/include/alkimia/Qt5/alkimia
  alkcompany.h  alk_export.h  alkquoteitem.h  alkvalue.h

This is required to support coinstallation of Qt4 and Qt5 variant of alkimia

% ls /usr/include/alkimia/Qt4/alkimia
tbaumgart accepted this revision.Mar 15 2018, 10:02 AM

Once you do it right, it works immediately.

This revision is now accepted and ready to land.Mar 15 2018, 10:02 AM
This revision was automatically updated to reflect the committed changes.