Differential D11277

Move package version definition to top level dir, which is common practice
ClosedPublic
Actions

Authored by habacker on Mar 13 2018, 7:18 AM.

Details

Reviewers
tbaumgart
Commits
R471:9ca57ffb26b0: Move package version definition to top level dir, which is common practice
Summary

CMake, starting with version 3.0.2, has support to specify project
version through the cmake project command in top level dir, which is
used by this commit.

With cmake > 2.8.13, the required "extra cmake modules" package
suggests using cmake's config helpers module instead of the one
provided by ECM.

Test Plan

compiled on linux

Diff Detail

Repository
R471 Alkimia Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
habacker requested review of this revision.Mar 13 2018, 7:18 AM
habacker created this revision.
tbaumgart requested changes to this revision.Mar 13 2018, 8:02 AM

I get the following warning when I apply this patch:

CMake Warning (dev) at /usr/share/ECM/modules/ECMPackageConfigHelpers.cmake:84 (message):
  Your project already requires a version of CMake that includes the
  find_dependency macro via the CMakeFindDependencyMacro module.  You should
  use CMakePackageConfigHelpers instead of ECMPackageConfigHelpers.
Call Stack (most recent call first):
  src/CMakeLists.txt:4 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

I assume this happens due to the change of

cmake_minimum_required(VERSION 2.8.12)

to

cmake_minimum_required(VERSION 3.0.2)

Can you check what's going on? TIA.

This revision now requires changes to proceed.Mar 13 2018, 8:02 AM
habacker added a comment.Mar 13 2018, 8:10 AM

With which versions of cmake and extra-cmake-modules package does this happens ?

tbaumgart added a comment.Mar 13 2018, 8:13 AM
In D11277#224451, @habacker wrote:

With which versions of cmake and extra-cmake-modules package does this happens ?

extra-cmake-modules-5.26.0-1.2.x86_64
cmake-3.5.2-1.2.x86_64

habacker updated this revision to Diff 29380.Mar 13 2018, 8:19 AM
habacker edited the summary of this revision. (Show Details)
  • fix warning
This revision is now accepted and ready to land.Mar 13 2018, 8:22 AM
Closed by commit R471:9ca57ffb26b0: Move package version definition to top level dir, which is common practice (authored by habacker). · Explain WhyMar 13 2018, 8:53 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (4 lines)
Msrc/CMakeLists.txt (18 lines)

Diff 29381

View Options

CMakeLists.txt

Loading...
View Options

src/CMakeLists.txt

Loading...