add tests for navigation bar
ClosedPublic
Actions

Authored by astippich on Mar 11 2018, 10:45 AM.

Details

Reviewers

mgallien

Group Reviewers

Elisa

Commits

R255:3a46c62259f6: add tests for navigation bar

Summary

add tests for the NavigationActionBar and implicitly for the StarRating

Repository

R255 Elisa

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

astippich requested review of this revision.Mar 11 2018, 10:45 AM

astippich created this revision.

Nice work. Really useful.

This revision is now accepted and ready to land.Mar 13 2018, 8:59 PM

I forgot to ask to put this in 0.1 branch and merge it in master after.

This revision was automatically updated to reflect the committed changes.

In D11227#225042, @mgallien wrote:

I forgot to ask to put this in 0.1 branch and merge it in master after.

What is the preferred procedure here? merge the 0.1 branch or cherry-pick the commits?

		Path
M		autotests/CMakeLists.txt (1 line)
A	M	autotests/qmltests/tst_NavigationActionBar.qml (326 lines)
M		src/qml/NavigationActionBar.qml (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	29216	15339f8		Mar 11 2018, 10:45 AM	★	★
Diff 2	29532	b38c3de	R255:3a46c62259f6c79546e830a055f9058ac098aeb2	Mar 14 2018, 8:58 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
04d83d3d1a05	1842d6ce70c2	15339f80988d	Alexander Stippich	add tests for navigation bar (Show More…)	Mar 11 2018, 10:43 AM