autotests: Restructure
ClosedPublic
Actions

Authored by michaelh on Mar 11 2018, 10:21 AM.

Details

Reviewers

Group Reviewers

Baloo
Frameworks

Commits

R824:b21a2ceeef83: autotests: Restructure

Summary

Move sample files to own folder
Use QFINDTESTDATA for extractortest

Test Plan

make test

Diff Detail

Repository

R824 Baloo Widgets

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

michaelh created this revision.Mar 11 2018, 10:21 AM

Restricted Application added a project: Baloo. · View Herald TranscriptMar 11 2018, 10:21 AM

michaelh requested review of this revision.Mar 11 2018, 10:21 AM

Doesn't build here:

../autotests/filemetadatawidgettest.cpp:22:10: fatal error: 'config.h' file not found

autotests: Remove obsolete includes

In D11226#223085, @elvisangelaccio wrote:
Doesn't build here:
../autotests/filemetadatawidgettest.cpp:22:10: fatal error: 'config.h' file not found

I wonder why it compiled here?
Edit: Should I more often make clean?

In D11226#223088, @michaelh wrote:
In D11226#223085, @elvisangelaccio wrote:
Doesn't build here:
../autotests/filemetadatawidgettest.cpp:22:10: fatal error: 'config.h' file not found
I wonder why it compiled here?
Edit: Should I more often make clean?

That's a good idea if you are changing something in the build system ;)

This revision is now accepted and ready to land.Mar 11 2018, 11:55 AM

Closed by commit R824:b21a2ceeef83: autotests: Restructure (authored by michaelh). · Explain WhyMar 11 2018, 12:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		autotests/CMakeLists.txt (2 lines)
D	M	autotests/config.h.in (27 lines)
M		autotests/extractortest.cpp (3 lines)
M		autotests/filemetadataitemcounttest.cpp (3 lines)
M		autotests/filemetadatawidgettest.cpp (19 lines)
V		autotests/{samplefiles ← }/test.mp3
V		autotests/{samplefiles ← }/testtagged.m4a
V		autotests/{samplefiles ← }/testtagged.mp3
V		autotests/{ → samplefiles}/test.mp3
V		autotests/{ → samplefiles}/testtagged.m4a
V		autotests/{ → samplefiles}/testtagged.mp3

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	29215	112bee9		Mar 11 2018, 10:19 AM	★	★
Diff 2	29219	112bee9	- autotests: Remove obsolete includes	Mar 11 2018, 11:44 AM	★	★
Diff 3	29222	112bee9	R824:b21a2ceeef83150caa519e6cccd284d2a5315563	Mar 11 2018, 12:03 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
bcf1ec82ef80	5763a6fd515b	9e70f7aab31d	Michael Heidelbach	autotests: Remove obsolete includes	Mar 11 2018, 11:44 AM
9e70f7aab31d	0a56bbd45523	0bbf220005ee	Michael Heidelbach	extractortest: Use QFINDTESTDATA	Mar 11 2018, 10:20 AM
0bbf220005ee	dc6aae8aa9d4	112bee9a900d	Michael Heidelbach	autotests: Create sample files folder	Mar 11 2018, 10:10 AM