As @ach pointed out, even after my last round of polish on the Add Source dialog, it was still too narrow, and many or even most URLs would not be fully visible in the text field. This patch remedies that, and now it can accommodate longer repo URLs without cutting anything off.
Details
Details
- Reviewers
apol - Group Reviewers
Discover Software Store - Commits
- R134:53f3ce95e634: Increase the "Add Source" dialog's width
with KDEApps Flatpak repo string, before:
After:
Diff Detail
Diff Detail
- Repository
- R134 Discover Software Store
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
I wonder if wit would make sense to make it in terms of the parent size too. Something like: width: Math.min(gridUnit*20, parent.width*0.8)
Comment Actions
For some reason Math.min (Kirigami.Units.gridUnit * 20, parent.width * 0.8) does not work, and always gives me the value of Kirigami.Units.gridUnit * 20, even when I can verify that alone width: parent.width*0.8 works fine. What's going on here? Is there an Import that we need for Math.min()?