Fix ActionButton size
ClosedPublic

Authored by icota on Mar 10 2018, 9:07 AM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:8a72bb018ded: Fix ActionButton size
Summary

Its dimensions were cut in half by the change in largeSpacing introduced in 735da5da3ab5c66855b76efe69c9b239ed158b3b.

Diff Detail

Repository
R169 Kirigami
Lint
Lint Skipped
Unit
Unit Tests Skipped
icota created this revision.Mar 10 2018, 9:07 AM
Restricted Application added a subscriber: plasma-devel. ยท View Herald TranscriptMar 10 2018, 9:07 AM
icota requested review of this revision.Mar 10 2018, 9:07 AM
icota edited the summary of this revision. (Show Details)Mar 10 2018, 1:50 PM

I think the real error is deriving the button size from a Spacing value and not a Size value. We should fix that, or else we'll have to do the same thing if we ever change the spacing again.

mart added a comment.Mar 12 2018, 3:35 PM

I think the real error is deriving the button size from a Spacing value and not a Size value. We should fix that, or else we'll have to do the same thing if we ever change the spacing again.

indeed, tough the idea was to size it depending on iconsizes and using the largespacing value as padding, which is a concept used a lot (would be space used outside the icon, so semantically would make sense).

i think the patch would be correct, following this reasoning

mart accepted this revision.Mar 12 2018, 3:35 PM
This revision is now accepted and ready to land.Mar 12 2018, 3:35 PM
icota closed this revision.Mar 14 2018, 7:18 AM