Its dimensions were cut in half by the change in largeSpacing introduced in 735da5da3ab5c66855b76efe69c9b239ed158b3b.
Details
Details
Diff Detail
Diff Detail
- Repository
- R169 Kirigami
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
I think the real error is deriving the button size from a Spacing value and not a Size value. We should fix that, or else we'll have to do the same thing if we ever change the spacing again.
Comment Actions
indeed, tough the idea was to size it depending on iconsizes and using the largespacing value as padding, which is a concept used a lot (would be space used outside the icon, so semantically would make sense).
i think the patch would be correct, following this reasoning