Load correct wallpaper plugin configuration in the dialog
ClosedPublic

Authored by aleksejshilin on Mar 9 2018, 10:03 PM.

Details

Summary

Wallpaper plugin was previously set for configDialog after StackView.
The latter, however, is using the former in its onSourceFileChanged
signal handler. As the result, it was using the previous wallpaper
plugin configuration instead of the current one.

Test Plan
  1. Right-click the desktop and click Configure Desktop.
  2. Select Wallpaper Type -> Plain Color. Click the chooser button and select green. Hit Apply.
  3. Select Wallpaper Type -> Haenau and click Apply.
  4. Select Plain Color type again. The color should still be green.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aleksejshilin created this revision.Mar 9 2018, 10:03 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 9 2018, 10:03 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
aleksejshilin requested review of this revision.Mar 9 2018, 10:03 PM
davidedmundson accepted this revision.Mar 10 2018, 1:09 AM
davidedmundson added a subscriber: davidedmundson.

I think there's a bug report about this somewhere if you want to find it.

This revision is now accepted and ready to land.Mar 10 2018, 1:09 AM

I think there's a bug report about this somewhere if you want to find it.

I've found quite a few similar ones (like 366390, 367546, 374691, 375532 etc.) - but they are all RESOLVED and don't reproduce (although it's mostly by accident). I haven't found one for this specific case, it's triggered only by choosing a type with no configuration like Haenau.

This revision was automatically updated to reflect the committed changes.