Differential D11193

Sonnet : use current hunspell API
ClosedPublic
Actions

Authored by rjvbb on Mar 9 2018, 8:40 PM.

Details

Reviewers
dfaure
mlaurent
vkrause
Group Reviewers
Frameworks
Commits
R246:0a96acf251ba: Use the current hunspell API
Summary

The hunspell backend uses three deprecated hunspell API functions; this patch fixes that.

Test Plan

Works as expected as far as I can tell.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
rjvbb created this revision.Mar 9 2018, 8:40 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 9 2018, 8:40 PM
rjvbb requested review of this revision.Mar 9 2018, 8:40 PM
rjvbb updated this revision to Diff 29246.Mar 11 2018, 2:53 PM

add missing context (patch unchanged)

rjvbb set the repository for this revision to R246 Sonnet.Mar 11 2018, 2:54 PM
rjvbb added a comment.Mar 24 2018, 2:54 PM

Any objections if I commit this by the end of the week?

dfaure accepted this revision.Mar 24 2018, 7:24 PM

Which version of hunspell does this raise the requirement to?

This revision is now accepted and ready to land.Mar 24 2018, 7:24 PM
rjvbb added a comment.Mar 24 2018, 8:25 PM
Which version of hunspell does this raise the requirement to?

1.5.1 it seems: https://github.com/hunspell/hunspell/commit/f90e69759203a945128b704a1b7037697a5113dd

Is that acceptable (that release is almost 2 years old by now)?

dfaure added a comment.Mar 24 2018, 8:41 PM

OpenSuSE Leap 42.3 (whose core packages are starting to get really old...) has hunspell-1.3.2-7.4.x86_64

Can you wait for a few months? OpenSuSE 15 should be released end of May.

rjvbb added a comment.Mar 24 2018, 9:21 PM

No problem if there's a good reason to wait!

Surprising that OpenSuSE has such an old hunspell but apparently a new enough Qt and other dependencies required for building Plasma5 desktops!
(My Ubuntu 14.04 also has hunspell 1.3.2 but is stuck on Qt 5.2 so I'm building most KF5 dependencies myself.)

Closed by commit R246:0a96acf251ba: Use the current hunspell API (authored by rjvbb). · Explain WhyJul 9 2018, 9:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 29246

View Options

src/plugins/hunspell/hunspelldict.cpp

Loading...