Differential D11189

Force a content size into the background style item
ClosedPublic
Actions

Authored by apol on Mar 9 2018, 7:28 PM.

Details

Reviewers

mart

Commits

R169:4b438abc8b15: Force a content size into the background style item

Summary

Otherwise the background will still be rendered without taking into
account the sizes we offer

Depends on D11190

Diff Detail

Repository

R169 Kirigami

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

apol created this revision.Mar 9 2018, 7:28 PM

Restricted Application added a project: Kirigami. · View Herald TranscriptMar 9 2018, 7:28 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

apol requested review of this revision.Mar 9 2018, 7:28 PM

ngraham added a subscriber: ngraham.Mar 9 2018, 8:09 PM

ngraham added inline comments.

src/controls/private/PrivateActionToolButton.qml
70	Magic number? Should that be `Kirigami.units.LargeSize` (18) or `Kirigami.units.MediumSize * 2` (16)?

apol added inline comments.Mar 9 2018, 10:57 PM

src/controls/private/PrivateActionToolButton.qml
70	It's just copying the logic that is used above.

mart added a subscriber: mart.Mar 12 2018, 3:27 PM

mart added inline comments.

src/controls/private/PrivateActionToolButton.qml
70	but why a static number at all? the problem is that the v arrow can be outside? but it's in the RowLayout, so its size should be taken into account in implicitWidth?

Remove a hardcoded size, so it's there just once.

Note this depends on D11190.

ngraham edited the summary of this revision. (Show Details)Mar 14 2018, 4:52 PM

ngraham added a dependency: D11190: Make sure we are taking into account hte size of the element when styling.

mart accepted this revision.Mar 28 2018, 7:59 PM

This revision is now accepted and ready to land.Mar 28 2018, 7:59 PM

Closed by commit R169:4b438abc8b15: Force a content size into the background style item (authored by apol). · Explain WhyMar 29 2018, 3:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/controls/private/PrivateActionToolButton.qml (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	29111	735da5d		Mar 9 2018, 7:28 PM	★	★
Diff 2	29505	8a72bb0	Remove a hardcoded size, so it's there just once.	Mar 14 2018, 2:35 PM	★	★
Diff 3	30853	e623154	R169:4b438abc8b154881f517abac0343c6ee5451bd0e	Mar 29 2018, 3:07 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
bcf30fbd24a9	067170d842f5	8a72bb018ded	Aleix Pol	Force a content size into the background style item (Show More…)	Mar 9 2018, 7:27 PM

	Status	Author	Revision
	Closed	apol	D11189 Force a content size into the background style item
	Closed	apol	D11190 Make sure we are taking into account hte size of the element when styling

Diff 30853

View Options

src/controls/private/PrivateActionToolButton.qml