Differential D11186

kio slaves aren't desktop applications but generic components
ClosedPublic
Actions

Authored by sitter on Mar 9 2018, 4:45 PM.

Details

Reviewers
elvisangelaccio
Commits
R219:fa68a420fc47: kio slaves aren't desktop applications but generic components
Summary

https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#sect-Metadata-GenericComponent
https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html

Diff Detail

Repository
R219 KIO GDrive
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter requested review of this revision.Mar 9 2018, 4:45 PM
sitter created this revision.
elvisangelaccio accepted this revision.Mar 10 2018, 4:30 PM

Should this go in the stable branch? (I have a new bugfix release planned)

This revision is now accepted and ready to land.Mar 10 2018, 4:30 PM
Closed by commit R219:fa68a420fc47: kio slaves aren't desktop applications but generic components (authored by sitter). · Explain WhyMar 12 2018, 2:23 PM
This revision was automatically updated to reflect the committed changes.
sitter added a comment.Mar 13 2018, 8:31 AM

@elvisangelaccio ah, sorry I missed your comment. It certainly would make sense.

The ultimate result of the wrong type is that an appstream generator (distro side tooling) implementation would discard the appdata as invalid as it won't be able to find the associated desktop file. At the same time, however, I don't think any of the app stores actually show generic components anyway, so I am not sure how much real-life impact this has outside distributions getting errors raised by their appstream generator.

Revision Contents
Changeset List

Diff 29332

View Options

desktop/org.kde.kio-gdrive.appdata.xml

Loading...