Differential D11171

Port NetworkAccessManager to new signal/slot syntax
ClosedPublic
Actions

Authored by malteveerman on Mar 9 2018, 9:11 AM.

Tags

Subscribers

Details

Reviewers

Group Reviewers

Commits

R181:12d7ecbfe6e8: Port NetworkAccessManager to new signal/slot syntax

Summary

This adds some template code to enable using NetworkAccessManager with member function pointers.

Diff Detail

Repository

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

malteveerman requested review of this revision.Mar 9 2018, 9:11 AM

malteveerman created this revision.

This does not build for me (GCC 7.2.0).

Error: https://pastebin.com/5Pmk1ELp

This revision now requires changes to proceed.Mar 13 2018, 7:23 PM

Previous diff relied on a function of QMetaObject added in Qt 5.10. This now works with older versions of Qt, too.

markey accepted this revision.Mar 14 2018, 7:18 PM

This revision is now accepted and ready to land.Mar 14 2018, 7:18 PM

Closed by commit R181:12d7ecbfe6e8: Port NetworkAccessManager to new signal/slot syntax (authored by malteveerman, committed by markey). · Explain WhyMar 14 2018, 7:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/context/applets/photos/plugin/PhotosEngine.cpp (3 lines)
M			src/covermanager/CoverFetcher.cpp (3 lines)
M			src/covermanager/CoverFoundDialog.cpp (3 lines)
M			src/network/NetworkAccessManagerProxy.h (91 lines)
M			src/network/NetworkAccessManagerProxy.cpp (174 lines)
M			src/scripting/scriptengine/AmarokNetworkScript.h (10 lines)
M			src/scripting/scriptengine/AmarokNetworkScript.cpp (13 lines)
M			src/services/ampache/AmpacheAccountLogin.cpp (6 lines)
M			src/services/ampache/AmpacheServiceQueryMaker.cpp (18 lines)

Diff 29438

src/context/applets/photos/plugin/PhotosEngine.cpp

Loading...

src/covermanager/CoverFetcher.cpp

Loading...

src/covermanager/CoverFoundDialog.cpp

Loading...

src/network/NetworkAccessManagerProxy.h

Loading...

src/network/NetworkAccessManagerProxy.cpp

Loading...

src/scripting/scriptengine/AmarokNetworkScript.h

Loading...

src/scripting/scriptengine/AmarokNetworkScript.cpp

Loading...

src/services/ampache/AmpacheAccountLogin.cpp

Loading...

src/services/ampache/AmpacheServiceQueryMaker.cpp

Loading...