Differential D11170

Use new kpackage_install_bundled_package macro
ClosedPublic
Actions

Authored by malteveerman on Mar 9 2018, 9:05 AM.

Details

Reviewers

markey

Group Reviewers

Amarok

Commits

R181:d98ec3f7a913: Use new kpackage_install_bundled_package macro

Summary

Using the new macro gets rid of some deprecation warnings and reduces the used disk space. Needs KPackage >= 5.41.

Diff Detail

Repository

R181 Amarok

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

malteveerman requested review of this revision.Mar 9 2018, 9:05 AM

malteveerman created this revision.

While I personally have no problem with requiring 5.41.0, it's maybe a bit new. Apparently the current Ubuntu doesn't have it and we should possibly wait until 18.04 is released (26.04.)

In D11170#222062, @heikobecker wrote:

While I personally have no problem with requiring 5.41.0, it's maybe a bit new. Apparently the current Ubuntu doesn't have it and we should possibly wait until 18.04 is released (26.04.)

Then I'll just keep this revision open until Ubuntu 18.04 comes out.

Just a rebase.

Ubuntu 18.04 is now released, and your patch builds fine with it.

This revision is now accepted and ready to land.May 10 2018, 6:58 AM

Restricted Application removed a project: Amarok. · View Herald TranscriptMay 10 2018, 6:58 AM

Restricted Application added a subscriber: amarok-devel. · View Herald Transcript

markey closed this revision.May 10 2018, 6:58 AM

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (2 lines)
M			src/context/AppletModel.cpp (6 lines)
M			src/context/CMakeLists.txt (2 lines)
M			src/context/ContextView.cpp (7 lines)
M			src/context/applets/albums/CMakeLists.txt (2 lines)
M			src/context/applets/analyzer/CMakeLists.txt (2 lines)
M			src/context/applets/currenttrack/CMakeLists.txt (2 lines)
M			src/context/applets/info/CMakeLists.txt (2 lines)
M			src/context/applets/lyrics/CMakeLists.txt (2 lines)
M			src/context/applets/photos/CMakeLists.txt (2 lines)
M			src/context/applets/wikipedia/CMakeLists.txt (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	29062	f96d0d1		Mar 9 2018, 9:02 AM	★	★
Diff 2	31425	adcbef1		Apr 5 2018, 8:49 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
0b9018c6bb13	a7893f8189a1	adcbef160f03	Malte Veerman	Use kpackage_install_bundled_package instead of kpackage_install_package. Needs… (Show More…)	Mar 18 2018, 8:27 PM