Improve metadata
ClosedPublic

Authored by apol on Mar 9 2018, 12:36 AM.

Details

Summary

Properly set the desktop filename.
Include an appstream file

Test Plan

Built locally

Diff Detail

Repository
R232 AtCore
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol requested review of this revision.Mar 9 2018, 12:36 AM
apol created this revision.
laysrodrigues requested changes to this revision.Mar 9 2018, 12:40 AM
This revision now requires changes to proceed.Mar 9 2018, 12:40 AM

What is the problem with that @laysrodrigues ?

What is the problem with that @laysrodrigues ?

He is using Atelier description for Atcore-gui.

apol added a comment.Mar 9 2018, 1:58 AM

Then give me an atcore description?

rizzitello requested changes to this revision.Mar 9 2018, 1:58 AM
rizzitello added inline comments.
testclient/org.kde.atcore.appdata.xml
27

Atcore Test Client (atcore-gui)

30

Something about how this will be replaced by atelier sometime in the future. Atcore test client allows you to connect to , send jobs, etc.. It does not save any settings since its main purpose is to allow easier testing of the atcore libary. Guess we also stuffed some toys in there.

35
36
38
rizzitello added inline comments.Mar 9 2018, 2:00 AM
testclient/org.kde.atcore.appdata.xml
35

atelier.kde.org

apol marked 6 inline comments as done.Mar 9 2018, 2:07 AM
apol updated this revision to Diff 29051.Mar 9 2018, 2:10 AM

Address comments

apol updated this revision to Diff 29052.Mar 9 2018, 2:13 AM

Use Lays's description

rizzitello added inline comments.Mar 9 2018, 2:37 AM
testclient/org.kde.atcore.appdata.xml
35

this project is LGPL 2+ . we never said other wise for the gui .

apol updated this revision to Diff 29077.Mar 9 2018, 11:47 AM

license

rizzitello accepted this revision.Mar 9 2018, 12:22 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 9 2018, 1:13 PM
Closed by commit R232:b562b9f7e10f: Improve metadata (authored by apol). · Explain Why
This revision was automatically updated to reflect the committed changes.