Use Meta modifier action for edges actions
AbandonedPublic

Authored by mvourlakos on Mar 8 2018, 11:11 PM.

Details

Reviewers
graesslin
Group Reviewers
KWin
Summary

--Update the activateLauncherMenu edge action in order to take
into account the user-set modifier dbus options. This way
kwin can forward to external apps(except plasmashell)
the activateLauncherMenu signal.

BUG: 391575

Test Plan

Check that the excecution to external apps is working

Diff Detail

Repository
R108 KWin
Branch
edgeapp
Lint
No Linters Available
Unit
No Unit Test Coverage
mvourlakos created this revision.Mar 8 2018, 11:11 PM
Restricted Application added a project: KWin. · View Herald TranscriptMar 8 2018, 11:11 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
mvourlakos requested review of this revision.Mar 8 2018, 11:11 PM
graesslin requested changes to this revision.Mar 9 2018, 5:18 AM
graesslin added a subscriber: graesslin.

Sorry, but this is magic. You cannot just redefine the application launcher setting to use a random other config value. You don't know what the user has configured. Imagine the user has set the meta key to a destructive action....

This revision now requires changes to proceed.Mar 9 2018, 5:18 AM
mvourlakos abandoned this revision.Mar 9 2018, 9:01 AM

ok no prob...

I thought that

list.at(3) == "activateLauncherMenu"

might be sufficient for this...

next stop a kwin script then...