Differential D11155

handle zip files embedded within zip files
ClosedPublic
Actions

Authored by sandsmark on Mar 8 2018, 3:03 PM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R243:07e5678981c6: handle zip files embedded within zip files
Summary

if we need to fetch the sizes from a PK78 header, there might be a PK34 header before it if there is a zip file embedded (e. g. an epub within a zip).

BUG: 73821
FIXED-IN: 5.47

Test Plan

autotest in a separate commit

Diff Detail

Repository
R243 KArchive
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sandsmark created this revision.Mar 8 2018, 3:03 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 8 2018, 3:03 PM
sandsmark requested review of this revision.Mar 8 2018, 3:03 PM
dfaure added inline comments.Mar 8 2018, 9:23 PM
kzip.cpp
347

can you document the new boolean param as well?

sandsmark updated this revision to Diff 33747.May 7 2018, 9:49 AM
sandsmark marked an inline comment as done.
In D11155#250677, @ngraham wrote:

Does this resolve https://bugs.kde.org/show_bug.cgi?id=73821?

I believe so

ngraham edited the summary of this revision. (Show Details)May 7 2018, 3:16 PM
dfaure accepted this revision.May 9 2018, 9:42 PM
This revision is now accepted and ready to land.May 9 2018, 9:42 PM
Closed by commit R243:07e5678981c6: handle zip files embedded within zip files (authored by sandsmark, committed by aacid). · Explain WhyMay 20 2018, 9:48 PM
This revision was automatically updated to reflect the committed changes.
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald TranscriptMay 20 2018, 9:48 PM

Revision Contents
Changeset List

Diff 34554

View Options

kzip.cpp

Loading...
View Options

src/kzip.cpp

Loading...