As there are quite a bit QML files in the respective /ui subdir, having the
JS file in another separate subdir named /code as befire provides
good overview
Details
- Reviewers
mart broulik hein - Group Reviewers
Plasma - Commits
- R119:600b64eb9ab8: Move applet packages' /code subdirs below /ui subdirs
Applets UI & Config still work as before
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Well, the package definition says JS files must (should) be in "code", I don't see the advantage of moving this.
That would the be another place to fix.
Motivation for this and the other patches is this from today:
[17:20] <frinring> notmart: hi. quick question: what is it with all the warnings "Warning: all files used by qml by the plasmoid should be in ui/." for *.js files which seem by standard located in the sibling "code/" directory instead? there are quite some during plasmashell run
[17:21] <frinring> is that a bogus warning which should be fixed for js files? or should js files be relocated in the future?
[17:25] <notmart> frinring: yeah, js files should be relocated in the future
[17:26] <frinring> notmart: what would be the new recommendation? ui/code/
[17:27] <notmart> frinring: we used to have a very complicated rewrite for accessing files for doing things like that and force js from there
[17:28] <notmart> then, profiling ended up eating a non trascurable time of bootup :)
[17:28] <notmart> frinring: so yeah, either in ui/ directly or in ui/code which is cleaner, so it doesn't weight onto that
There's no advantage to that rule though.
Also AFAIR there's a warning that complains about that.