In D11147#221123, @rkflx wrote:

Sorry for not keeping you in the loop. We only had the best intentions ;) Feel free to remind us again if we forget to bump something.

No need for excuse

Could you tell us more about the ideal doc workflow? Currently we tried to update the docbook (in Spectacle, mainly) as soon as we changed something. Do you prefer we'd not do that and instead to write it all yourself? Or perform docbook changes always in a follow-up patch in order to avoid spamming the doc team with excessive technical review noise?

Your workflow updating the docbook together with the code change is really appreciated, thanks.
Getting mails on kde-doc-english@kde.org about documentation related changes in GUI or docbook is definitely no spam ;-)

The documentation team gets a mail on kde-doc-english@kde.org via a hook implemented by our famous sysadmins about any commit where a docbook is changed or added.
But that is too late for the documentation team to comment on a current review.
Therefore lease add the group Documentation as reviewer for any change related to GUI or docbook content

Thanks a lot

And perhaps our friendly sysadmins can work their magic to have Phabricator automatically add the Documentation group to any differential revision that touches a docbook file?

@lueck Quick question regarding your test plan. Is this normal/expected or should we change something:

$ checkXML5 index.docbook 
Note: namesp. add : added namespace before processing              Gwenview User Manual

In D11147#221578, @rkflx wrote:

@lueck Quick question regarding your test plan. Is this normal/expected or should we change something:

$ checkXML5 index.docbook 
Note: namesp. add : added namespace before processing              Gwenview User Manual

I don't get this output and I have never seen this as output of checkXML5
I am using docbook5-xml 5.0-2, is your version different?

In D11147#221141, @ngraham wrote:

And perhaps our friendly sysadmins can work their magic to have Phabricator automatically add the Documentation group to any differential revision that touches a docbook file?

This Feature was added by our friendly sysadmins with https://phabricator.kde.org/T8164

Awesome!

In D11147#221820, @lueck wrote:

In D11147#221141, @ngraham wrote:

And perhaps our friendly sysadmins can work their magic to have Phabricator automatically add the Documentation group to any differential revision that touches a docbook file?

This Feature was added by our friendly sysadmins with https://phabricator.kde.org/T8164

The task is restricted, I cannot see it. Also I wonder if it is really necessary to make Documentation a "blocking reviewer", wouldn't a regular group reviewer have been enough? Nevertheless, thanks for adding it ;)

In D11147#221693, @lueck wrote:

In D11147#221578, @rkflx wrote:

@lueck Quick question regarding your test plan. Is this normal/expected or should we change something:

$ checkXML5 index.docbook 
Note: namesp. add : added namespace before processing              Gwenview User Manual

I don't get this output and I have never seen this as output of checkXML5
I am using docbook5-xml 5.0-2, is your version different?

I used docbook 4.5 (kdoctools depends on that in Tumbleweed), but it turns out the problem was with docbook-xsl-stylesheets: Migrating to the latest version from the main repo, the warning is gone again.

Anyway, that problem is/was OT for this patch, which should be ready for arc land now, pending acceptance from Documentation.

Don't add Documentation as reviewer; just add it as subscriber.

@lueck This landed in d883cdcdc1ea, please close this Diff.

Just use arc land next time, it prevents typos, adds the test plan and the reviewers to the commit message and does more awesome things ;)