Add ConnectionCheck for Dash Cards
ClosedPublic
Actions

Authored by Aiix on Mar 7 2018, 7:07 PM.

Details

Reviewers

None

Group Reviewers

Plasma

Commits

R846:7a9795631062: Add ConnectionCheck for Dash Cards

Summary

Check if there is an internet connection available before displaying information cards

Ping example.com to check connection availability
Wait for active internet connection to connect to plasma geolocation datasource
Do not display information cards in not connected as they are dependent on GeoLocation data

Repository

R846 Mycroft Plasma integration

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Aiix requested review of this revision.Mar 7 2018, 7:07 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 7 2018, 7:07 PM

This revision was automatically updated to reflect the committed changes.

yurchor added inline comments.

plasmoid/contents/ui/main.qml
132	Is it necessary to use "🌐" between "the" and "internet" in this message? Thanks in advance for your answer.

plasmoid/contents/ui/main.qml
132	Thanks for reviewing this, I wasn't sure if there is general issue on using Unicode symbols in strings and rather a shortcut to not using a icon instead, will fix it.

		Path
M		CMakeLists.txt (1 line)
M		plasmoid/contents/ui/main.qml (60 lines)
M		plugin/CMakeLists.txt (4 lines)
A	M	plugin/connectioncheck.h (38 lines)
A	M	plugin/connectioncheck.cpp (41 lines)
M		plugin/mycroftplasmoidplugin.cpp (12 lines)