Stop the auto-scroll from staying on with some tools

Authored by scottpetrovic on Mar 7 2018, 6:29 PM.


Group Reviewers

Right now the auto-scroll sometimes gets stuck with tools that have it enabled. This makes Krita difficult to work with as trying to pan back to the canvas auto-scrolls it to outside the canvas again.

Test Plan

I cannot get it to reproduce 100%, but this is the closest I can get to steps to get it.

  1. Create a new canvas (1600 x 1200)
  2. Select Crop Tool and click on the canvas (selecting the bounds of the canvas)
  3. Hold down the space bar while in the active canvas area
  4. Repeatedly try to pan the canvas from in the canvas area to the lower right GUI area with the zoom slider.

I tested it on Ubuntu 17.10 VM. It seems to get stuck about 30% of the time.

Diff Detail

R37 Krita
Lint Skipped
Unit Tests Skipped
scottpetrovic requested review of this revision.Mar 7 2018, 6:29 PM
scottpetrovic created this revision.
rempt accepted this revision.Mar 8 2018, 8:46 AM
This revision is now accepted and ready to land.Mar 8 2018, 8:46 AM

Pushed. I tested this on my surface pro 4 as well. It seems it is much more common if the steps are done with the mouse. Applying this patch seemed to fix the issue.

scottpetrovic closed this revision.Mar 8 2018, 2:28 PM