overflow-menu as view-more-symbolic, and horizontal
ClosedPublic

Authored by mart on Mar 7 2018, 5:56 PM.

Details

Summary

use the 3 dots icons as view-more-symbolic, as traditionally in
the iconography of most systems those are for menus of actions
that didn't fit in a toolbar (as the overflow-menu name tells)
while the 3 lines one means the main menu of an application and
should always appear at most in a single place in a whole app
this makes it less confusing as users will use our apps together
apps written in other toolkits, web pages where this is common as
well, as well apps on their phones which will all use this paradigm.

adapt the horizontal version too, to look like what firefox uses
tough i would make it black as well, as now it may always look disabled

Test Plan

shown the mixer applet (which will need its own rr) which looks lighter
and causes less confusion between the global panel menu icon and the little
overflow menus of the mixer items

Diff Detail

Repository
R266 Breeze Icons
Branch
phab/overflow
Lint
No Linters Available
Unit
No Unit Test Coverage
mart created this revision.Mar 7 2018, 5:56 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 7 2018, 5:56 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
mart requested review of this revision.Mar 7 2018, 5:56 PM
mart changed the visibility from "Public (No Login Required)" to "No One".Mar 7 2018, 5:56 PM
mart updated this revision to Diff 28967.Mar 7 2018, 5:59 PM

smaller svgs

mart changed the visibility from "No One" to "Public (No Login Required)".Mar 7 2018, 6:00 PM
Fuchs added a subscriber: Fuchs.Mar 12 2018, 3:23 PM

Yes, I very much like the overflow and the usage you describe, as per the discussion on Telegram and https://phabricator.kde.org/D11231, I think mixer is however not an example where it should be used, because in the mixer it's not an overflow of functionality, but rather a menu on its own.

So +1 for this request here, the change on the mixer I'd -1 though.

andreaska accepted this revision.Apr 17 2018, 9:11 AM
This revision is now accepted and ready to land.Apr 17 2018, 9:11 AM
This revision was automatically updated to reflect the committed changes.

This change broke the CI: https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/76/

[ 62%] Building CXX object autotests/CMakeFiles/scalable.dir/scalable_autogen/mocs_compilation.cpp.o
./icons-dark/actions/symbolic/view-more-horizontal-symbolic.svg:16: namespace error : Namespace prefix inkscape for connector-curvature on path is not defined
sodipodi:nodetypes="ccccccccccccccc" />
^
./icons-dark/actions/symbolic/view-more-horizontal-symbolic.svg:16: namespace error : Namespace prefix sodipodi for nodetypes on path is not defined
sodipodi:nodetypes="ccccccccccccccc" />
^
./icons/actions/symbolic/view-more-horizontal-symbolic.svg:16: namespace error : Namespace prefix inkscape for connector-curvature on path is not defined
sodipodi:nodetypes="ccccccccccccccc" />
^
./icons/actions/symbolic/view-more-horizontal-symbolic.svg:16: namespace error : Namespace prefix sodipodi for nodetypes on path is not defined
sodipodi:nodetypes="ccccccccccccccc" />
^