Add X-KDE-OnlyShowOnQtPlatforms to KCModule servicetype definition
ClosedPublic

Authored by kossebau on Mar 7 2018, 1:43 PM.

Details

Summary

KCoreAddons' DesktopFileParser needs a definition of the types of all
possible entries to do a proper conversion to JSON types.
It is also nicer for plugin developers to have that type documented.

Diff Detail

Repository
R295 KCMUtils
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Mar 7 2018, 1:43 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 7 2018, 1:43 PM
kossebau requested review of this revision.Mar 7 2018, 1:43 PM

And seems there is also code for handling X-KDE-NotShowOnQtPlatforms in KService::showOnCurrentPlatform() (but not in kded custom code).
lxr.kde.org tells that method is used by

  • plasma-phone-components/containments/homescreen/applicationlistmodel.cpp -> seems to use it as custom key extension to "Application" type, so would need custom documentation, ignoring for now
  • powerdevil/daemon/powerdevilactionpool.cpp -> PowerDevil/Action servicetype, without any definition, though also no service plugins found, ignoring for now

Just mentioning for completeness, perhaps interesting to someone.

apol accepted this revision.Mar 7 2018, 3:22 PM
This revision is now accepted and ready to land.Mar 7 2018, 3:22 PM
This revision was automatically updated to reflect the committed changes.