Fix build after deprecated QFontMetrics::width()
ClosedPublic

Authored by carewolf on Mar 7 2018, 11:01 AM.

Details

Summary

It was deprecated for not reporting the actual width but horizontal advance. Use the actual bounding width instead and don't claim to support future deprecations.

Diff Detail

Repository
R459 Akonadi Contacts
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
carewolf created this revision.Mar 7 2018, 11:01 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 7 2018, 11:01 AM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
carewolf requested review of this revision.Mar 7 2018, 11:01 AM

What is your error ?
I didn't see an error yesterday when I build against qt5.11

carewolf updated this revision to Diff 29000.Mar 8 2018, 11:32 AM

Updated to not used the depecated API

carewolf retitled this revision from Fix building with Qt 5.11 to Fix build after deprecated QFontMetrics::width().Mar 8 2018, 11:33 AM
carewolf edited the summary of this revision. (Show Details)
mlaurent accepted this revision.Mar 8 2018, 12:30 PM
This revision is now accepted and ready to land.Mar 8 2018, 12:30 PM

Ah, sorry wrong branch. Didnt notice it had a default upstream set.

This revision was automatically updated to reflect the committed changes.