Differential D11109

[Notifications] Remove NoAccessNetworkAccessManagerFactory
ClosedPublic
Actions

Authored by broulik on Mar 7 2018, 8:52 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:71f168818439: [Notifications] Remove NoAccessNetworkAccessManagerFactory
Summary

With shared QML engine this would affect all applets and since we properly escape HTML in notifications now this is unneccessary.

Test Plan

5.12 branch

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 7 2018, 8:52 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 7 2018, 8:52 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Mar 7 2018, 8:52 AM
davidedmundson accepted this revision.Mar 13 2018, 2:13 PM
This revision is now accepted and ready to land.Mar 13 2018, 2:13 PM
Closed by commit R120:71f168818439: [Notifications] Remove NoAccessNetworkAccessManagerFactory (authored by broulik). · Explain WhyMar 13 2018, 3:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 29415

View Options

applets/notifications/plugin/notificationshelperplugin.h

Loading...
View Options

applets/notifications/plugin/notificationshelperplugin.cpp

Loading...