Differential D11108

Set supported schemes to "file" for getsavefilename
ClosedPublic
Actions

Authored by broulik on Mar 7 2018, 8:21 AM.

Details

Reviewers
dfaure
Commits
R229:975a49b3494b: Set supported schemes to "file" for getsavefilename
Summary

This was done in getopenfilename but not getsavefilename.
Since it calls selectedFiles when the dialog is accepted, any non-file URL will result in an empty return value.

Test Plan

No longer get Trash and "Recently Saved" places shown when calling getsavefilename (e.g. "Save As" in Chromium) but it still works in getsaveurl

Diff Detail

Repository
R229 KDialog
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik requested review of this revision.Mar 7 2018, 8:21 AM
broulik created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Apr 5 2018, 1:08 PM
Closed by commit R229:975a49b3494b: Set supported schemes to "file" for getsavefilename (authored by broulik). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kdialog.cpp (6 lines)

Diff 31393

View Options

src/kdialog.cpp

Loading...