Differential D11099

Fix compilation on Android
AbandonedPublic
Actions

Authored by vkrause on Mar 6 2018, 5:32 PM.

Details

Reviewers
None
Group Reviewers
Frameworks

Diff Detail

Repository
R244 KCoreAddons
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
vkrause created this revision.Mar 6 2018, 5:32 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 6 2018, 5:32 PM
vkrause requested review of this revision.Mar 6 2018, 5:32 PM
apol added a subscriber: apol.Mar 7 2018, 12:55 AM

I actually hit this issue this week (you can see build.kde.org failing earlier this week:
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20AndroidQt5.9/

I fixed it by using android-21 as the sdk version, maybe it's a more acceptable compromise?
I'm not sure what we are compromising over though.

src/lib/caching/kshareddatacache_p.h
405

There's a weird whitespace here.

406

#else Q_UNREACHABLE?
Or what happens?

vkrause added a comment.Mar 7 2018, 9:11 AM

I also needed API level 21 to make this work, but this changes seemed necessary independent of that, and matches what the above method does for KSDC_TIMEOUTS_SUPPORTED.

vkrause abandoned this revision.Jun 21 2018, 2:33 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald TranscriptJun 21 2018, 2:33 PM

Revision Contents
Changeset List

Diff 28851

View Options

src/lib/caching/kshareddatacache_p.h

Loading...