Differential D11098

use opacity instead of visible
ClosedPublic
Actions

Authored by mart on Mar 6 2018, 3:57 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R119:3a763498b6a4: use opacity instead of visible
R119:eff339237986: use opacity instead of visible
Summary

Qt documentation recomends to bind to opacity instead of visible as visible
cascades down. The tabbar used to trigger its height behavior anim when the
popup got hidden, binding to opacity (even if opacity isn't animated) is a
more correct behavior.
Plus with visible it triggers the Qt bug https://bugreports.qt.io/browse/QTBUG-66907
which in turn triggers https://bugs.kde.org/show_bug.cgi?id=391432

BUG:391432

Test Plan

kickoff never opens the last tab anymore

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Mar 6 2018, 3:57 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 6 2018, 3:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Mar 6 2018, 3:57 PM
davidedmundson accepted this revision.Mar 6 2018, 3:59 PM
This revision is now accepted and ready to land.Mar 6 2018, 3:59 PM
Closed by commit R119:3a763498b6a4: use opacity instead of visible (authored by mart). · Explain WhyMar 6 2018, 4:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 28842

View Options

applets/kickoff/package/contents/ui/FullRepresentation.qml

Loading...