Differential D11097

[Window Thumbnail] Allow using atlas texture
ClosedPublic
Actions

Authored by broulik on Mar 6 2018, 2:10 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R242:48771a291229: [Window Thumbnail] Allow using atlas texture
Summary

It's not using any custom shaders anyway

Test Plan

Verified thumbnails still look good
Verified fallback to window icon still looks good

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 6 2018, 2:10 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 6 2018, 2:10 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
broulik requested review of this revision.Mar 6 2018, 2:10 PM
davidedmundson accepted this revision.Mar 6 2018, 2:12 PM
This revision is now accepted and ready to land.Mar 6 2018, 2:12 PM
Closed by commit R242:48771a291229: [Window Thumbnail] Allow using atlas texture (authored by broulik). · Explain WhyMar 6 2018, 2:14 PM
This revision was automatically updated to reflect the committed changes.
davidedmundson added a comment.Mar 6 2018, 2:17 PM

Edit.

Just re-read. Sorry.

createTextureFromId with CanUseAtlas doesn't make any sense.

It creates a QSGTexture object from an existing GL Texture, it's not creating any atlas or otherwise.

It'll just no-op. So no harm done.

Revision Contents
Changeset List

Diff 28834

View Options

src/declarativeimports/core/windowthumbnail.cpp

Loading...