Ported pages for contextmenu, dropdown, menubar, splitter to rst
ClosedPublic

Authored by fabianr on Mar 6 2018, 11:11 AM.

Details

Summary

Ported pages for contextmenu, dropdown, menubar, splitter to rst. Whitespace fix. Added pages to index.

Diff Detail

Repository
R985 KDE Human Interface Guidelines
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
fabianr requested review of this revision.Mar 6 2018, 11:11 AM
fabianr created this revision.
romangg added inline comments.Mar 7 2018, 5:08 PM
source/components/contextmenu.rst
58

The line breaks here seem to be random. In other bullet points as well. Or is this not an issue in reST text?

source/components/dropdown.rst
76

With a what?

fabianr added inline comments.Mar 7 2018, 6:54 PM
source/components/contextmenu.rst
58

As far as I know a single line break is not relevant. What is relevant is indentation.

The paragraph (ref) is the most basic block in a reST document. Paragraphs are simply chunks of text separated by one or more blank lines. As in Python, indentation is significant in reST, so all lines of the same paragraph must be left-aligned to the same level of indentation.

The tool I use to convert the pages inserts line breaks after about 70 characters. I only edit the lines if I have to change the markup, eg links.

fabianr updated this revision to Diff 28979.Mar 7 2018, 7:19 PM

Added missing content in dropdown

You removed accidentally all the other stuff.

fabianr updated this revision to Diff 28989.Mar 8 2018, 8:49 AM
  • Added missing content in dropdown
romangg accepted this revision.Mar 11 2018, 1:21 PM
This revision is now accepted and ready to land.Mar 11 2018, 1:21 PM
fabianr closed this revision.Mar 12 2018, 8:49 AM