Differential D11091

Support Atlas textures in FadingNode
ClosedPublic
Actions

Authored by davidedmundson on Mar 6 2018, 11:10 AM.

Details

Reviewers

broulik

Group Reviewers

Plasma

Commits

R242:02c419453462: Support Atlas textures in FadingNode

Summary

Previously IconItem would create icons in new textures for animating. By
keeping them in the atlas not only do we avoid that, but we should
implicitly share the QSGTexture used for non-animating item.

Test Plan

Moused over icon, it changed correctly
Set core profile, moused over an icon it changed correctly

Diff Detail

Repository

R242 Plasma Framework (Library)

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidedmundson created this revision.Mar 6 2018, 11:10 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptMar 6 2018, 11:10 AM

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

davidedmundson requested review of this revision.Mar 6 2018, 11:10 AM

broulik accepted this revision.Mar 6 2018, 12:29 PM

This revision is now accepted and ready to land.Mar 6 2018, 12:29 PM

Closed by commit R242:02c419453462: Support Atlas textures in FadingNode (authored by davidedmundson). · Explain WhyMar 6 2018, 12:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/declarativeimports/core/fadingmaterial.frag (6 lines)
M			src/declarativeimports/core/fadingmaterial_core.frag (6 lines)
M			src/declarativeimports/core/fadingnode.cpp (9 lines)
M			src/declarativeimports/core/iconitem.cpp (4 lines)