Differential D11080

Make org.kde. components include a donate URL
ClosedPublic
Actions

Authored by apol on Mar 6 2018, 12:42 AM.

Details

Reviewers
None
Group Reviewers
Frameworks
Commits
R290:af8721a5ccca: Make org.kde. components include a donate URL
Summary

AppStream can offer information to donate about a product, we better point our
happy users to the right direction.

Test Plan

output validates successfully against appstreamcli

Diff Detail

Repository
R290 KPackage
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol created this revision.Mar 6 2018, 12:42 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 6 2018, 12:42 AM
apol requested review of this revision.Mar 6 2018, 12:42 AM
aacid added a subscriber: aacid.Mar 6 2018, 8:31 AM
aacid added inline comments.
src/kpackagetool/kpackagetool.cpp
534

Not sure if i'm saying crap, but should we check if it already has a donation url and then give a warning or something else?

apol added inline comments.Mar 6 2018, 2:19 PM
src/kpackagetool/kpackagetool.cpp
534

This is for the code that turns kpackage metadata files into appdata.xml files. So it doesn't really apply.

apol updated this revision to Diff 28835.Mar 6 2018, 2:26 PM

Include the app id when opening the url, to inform what's the donation trigger

This revision was not accepted when it landed; it landed in state Needs Review.Mar 19 2018, 1:43 AM
Closed by commit R290:af8721a5ccca: Make org.kde. components include a donate URL (authored by apol). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kpackagetool/kpackagetool.cpp (8 lines)

Diff 28835

View Options

src/kpackagetool/kpackagetool.cpp

Loading...