Make org.kde. components include a donate URL
ClosedPublic
Actions

Authored by apol on Mar 6 2018, 12:42 AM.

Details

Reviewers

None

Group Reviewers

Frameworks

Commits

Summary

AppStream can offer information to donate about a product, we better point our
happy users to the right direction.

Test Plan

output validates successfully against appstreamcli

Repository

R290 KPackage

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

apol requested review of this revision.Mar 6 2018, 12:42 AM

aacid added inline comments.

src/kpackagetool/kpackagetool.cpp
534	Not sure if i'm saying crap, but should we check if it already has a donation url and then give a warning or something else?

src/kpackagetool/kpackagetool.cpp
534	This is for the code that turns kpackage metadata files into appdata.xml files. So it doesn't really apply.

Include the app id when opening the url, to inform what's the donation trigger

This revision was not accepted when it landed; it landed in state Needs Review.Mar 19 2018, 1:43 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/kpackagetool/kpackagetool.cpp (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	28775	6dd44d8		Mar 6 2018, 12:42 AM	★	★
Diff 2	28835	6dd44d8	Include the app id when opening the url, to inform what's the donation trigger	Mar 6 2018, 2:26 PM	★	★
Diff 3	29877	9637663	R290:af8721a5ccca9629ee4ffb884ac7ab5b633aabff	Mar 19 2018, 1:42 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
1e38739d593c	a42812a5cf4e	6dd44d869c6c	Aleix Pol	Make org.kde. components include a donate URL (Show More…)	Mar 6 2018, 12:42 AM