Fix compiling autotests on Windows
ClosedPublic

Authored by habacker on Mar 6 2018, 12:01 AM.

Details

Summary

QtTest library is named QtTest4 on Windows, use cmake variable
QT_QTTEST_LIBRARY for a platform independent solution.

Test Plan

cross compiled for Windows

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
habacker requested review of this revision.Mar 6 2018, 12:01 AM
habacker created this revision.

Is this to be meant to end up in master? Master is not meant to be used for Qt4. Or am I missing an important detail here?

Is this to be meant to end up in master? Master is not meant to be used for Qt4. Or am I missing an important detail here?

master has Qt4 support as well as 7.0 branch, so it requires this patch too.

In general Qt4 support will be required as long as there is no stable kmymoney5 release on Windows including all supported plugins.

You are right, but there is no mention that this is for the alkimia repo (try Ctrl-F and look for alimia). I thought it would be a pathc for KMyMoney. That is a different story then and everything is OK.

habacker set the repository for this revision to R471 Alkimia Library.Mar 7 2018, 7:18 AM

Please accept

tbaumgart accepted this revision.Mar 7 2018, 9:35 AM

I did not test it myself against a Qt4 installation, but it looks OK to me.

This revision is now accepted and ready to land.Mar 7 2018, 9:35 AM
This revision was automatically updated to reflect the committed changes.