Differential D11068

Fix runtime appmetadata: ensure translations, dektopFileName, window icon
ClosedPublic
Actions

Authored by kossebau on Mar 5 2018, 8:13 PM.

Details

Reviewers
apol
Commits
R474:54c4057128b6: Fix runtime appmetadata: ensure translations, dektopFileName, window icon
Summary

Also fixes non-working -v cmld argument handling

Diff Detail

Repository
R474 Kamoso
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau requested review of this revision.Mar 5 2018, 8:13 PM
kossebau created this revision.
kossebau added a comment.Mar 5 2018, 8:16 PM

If okay, master or 3.2 branch? Any 3.2.4 release planned (with the updated translations?)

kossebau retitled this revision from Fix runtime appmetadata: ensure translations, set window icon explicitly to Fix runtime appmetadata: ensure translations, dektopFileName, window icon.Mar 5 2018, 8:21 PM
apol added a comment.Mar 6 2018, 12:31 AM

I don't think we are going to have any further releases from 3.2 since 3.3 should come with KDE Applications and Albert told me translations had already been moved about. Master should be fine. If you push to the 3.2 branch, it's fine too.

apol accepted this revision.Mar 6 2018, 12:31 AM
This revision is now accepted and ready to land.Mar 6 2018, 12:31 AM
Closed by commit R474:54c4057128b6: Fix runtime appmetadata: ensure translations, dektopFileName, window icon (authored by kossebau). · Explain WhyMar 6 2018, 3:16 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/main.cpp (16 lines)

Diff 28779

View Options

src/main.cpp

Loading...