[mediacontroller applet] Reorder elements
ClosedPublic

Authored by romangg on Mar 5 2018, 3:55 PM.

Details

Summary

Improve overall look according to bug report and mockup.

BUG: 390280

Diff Detail

Repository
R120 Plasma Workspace
Branch
mediaAppletStructure
Lint
No Linters Available
Unit
No Unit Test Coverage
romangg created this revision.Mar 5 2018, 3:55 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 5 2018, 3:55 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
romangg requested review of this revision.Mar 5 2018, 3:55 PM
romangg edited the summary of this revision. (Show Details)Mar 5 2018, 3:56 PM
romangg added inline comments.
applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
291

Pls tell me a way to use Headings without huge margins all around.

broulik added a subscriber: broulik.Mar 5 2018, 5:52 PM

Cool!

applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
123

Math.round

124

Why is this thing no longer in a ColumLayout?

193

cnthrwueif..what?

291

height: undefined

302

Add braces

304
return root.artist ? i18nc("artist - track", "%1 – %2", root.artist, root.track) : root.track
312

Why not use a ColumnLayout?

313

I thought level only went up to 5 but fine with me

319

So you now use the file name as "album"? How does it behave when you have no id3 info at all?

359

Not neccessary, that item is full width already

romangg updated this revision to Diff 28772.Mar 5 2018, 11:57 PM
  • [mediacontroller applet] App icon when cover not available
andreask accepted this revision.Mar 6 2018, 11:01 AM
This revision is now accepted and ready to land.Mar 6 2018, 11:01 AM
romangg updated this revision to Diff 28816.Mar 6 2018, 12:04 PM
romangg marked 7 inline comments as done.
  • Comments by Kai
applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
124

I want to have the controls always at the same fixed position at the bottom of the applet. With a layout it would shift them around according to the content available (which you can probably block somehow, but I couldn't really get it to work and using anchors or simple columns to achieve this seems more straightforward to me anyway).

291

If I forget this trick one more time, hit me.

312

As above. I want to have this stuff always at fixed positions. Or is there a simple way to achieve this with Layouts as well?

313

Yea, you're right. It just interprets everything above 5 as 5.

319

I don't have changed anything in this regard.

abetts added a subscriber: abetts.Mar 6 2018, 3:08 PM

Not sure if it is within the scope of this patch but the spacing is uneven vertically between elements in the notification window. They need more space to breathe.

Media Player
Cover Artwork
Progress Bar

Song Title

Media Controls
Window bottom edge

It should be:

Media Player

Cover Artwork

Progress Bar

Song Title

Media Controls

Window bottom edge

ngraham added a subscriber: ngraham.Mar 6 2018, 3:14 PM

Not sure if it is within the scope of this patch but the spacing is uneven vertically between elements in the notification window. They need more space to breathe.

Media Player
Cover Artwork
Progress Bar

Song Title

Media Controls
Window bottom edge

It should be:

Media Player

Cover Artwork

Progress Bar

Song Title

Media Controls

Window bottom edge

IMHO that would be way too much whitespace. We already get a lot of user complaints that Plasma widgets and menus have excessive padding and whitespace.

romangg updated this revision to Diff 28889.Mar 7 2018, 8:43 AM

Rebased on master

broulik accepted this revision.Mar 7 2018, 8:55 AM

Go go go :)

applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
174–178

usesPlasmaTheme: false

romangg updated this revision to Diff 28892.Mar 7 2018, 9:07 AM
  • Minor changes proposed by Kai
romangg marked an inline comment as done.Mar 7 2018, 9:07 AM
This revision was automatically updated to reflect the committed changes.