[mediacontroller applet] Use media playback status icons
ClosedPublic

Authored by romangg on Mar 5 2018, 1:24 PM.

Details

Summary

Instead of using the action icons to indicate the current state use
the new media playback status icons.

This is an alternative solution to the problem that the mediacontroller applet
icon in the system tray and the play/pause controll in the player are always
the opposite.

While it is still the opposite icon there is now a slight visual difference
to show that these icons mean different things.

This is meant as a solution to the problem discussed in D10032.

Diff Detail

Repository
R120 Plasma Workspace
Branch
mediaAppletStatusIcon
Lint
No Linters Available
Unit
No Unit Test Coverage
romangg created this revision.Mar 5 2018, 1:24 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 5 2018, 1:24 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
romangg requested review of this revision.Mar 5 2018, 1:24 PM
romangg edited the summary of this revision. (Show Details)
romangg edited the summary of this revision. (Show Details)Mar 5 2018, 1:29 PM

Should we add a fallback mechanism in case the icon pack does not contain the media playback state icons? I mean as a fallback the normal media-playback-start and pause icons again as it is now.

andreask accepted this revision.Mar 6 2018, 11:01 AM
This revision is now accepted and ready to land.Mar 6 2018, 11:01 AM
romangg updated this revision to Diff 28902.Mar 7 2018, 9:47 AM

Rebase on master

broulik accepted this revision.Mar 7 2018, 10:01 AM

Can you please also update the tooltip

broulik resigned from this revision.Mar 7 2018, 10:03 AM
broulik requested changes to this revision.
This revision now requires changes to proceed.Mar 7 2018, 10:03 AM
romangg updated this revision to Diff 28906.Mar 7 2018, 10:30 AM
  • Also change tooltip icon
broulik accepted this revision.Mar 7 2018, 10:31 AM
This revision is now accepted and ready to land.Mar 7 2018, 10:31 AM
This revision was automatically updated to reflect the committed changes.