Rename NetworkPackage -> NetworkPacket
ClosedPublic
Actions

Authored by albertvaka on Mar 4 2018, 9:33 PM.

Details

Reviewers

apol
nicolasfella

Group Reviewers

KDE Connect

Commits

R224:f47f51782719: Rename NetworkPackage -> NetworkPacket

Summary

KDE Connect, now with correct naming!

Test Plan

It still builds.

Diff Detail

Repository

R224 KDE Connect

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

albertvaka requested review of this revision.Mar 4 2018, 9:33 PM

albertvaka created this revision.

Missing change

apol accepted this revision.Mar 5 2018, 12:58 AM

This revision is now accepted and ready to land.Mar 5 2018, 12:58 AM

LGTM

Closed by commit R224:f47f51782719: Rename NetworkPackage -> NetworkPacket (authored by albertvaka). · Explain WhyMar 5 2018, 7:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			core/CMakeLists.txt (2 lines)
M			core/backends/bluetooth/bluetoothdevicelink.h (2 lines)
M			core/backends/bluetooth/bluetoothdevicelink.cpp (24 lines)
M			core/backends/bluetooth/bluetoothlinkprovider.cpp (42 lines)
M			core/backends/bluetooth/bluetoothpairinghandler.h (4 lines)
M			core/backends/bluetooth/bluetoothpairinghandler.cpp (26 lines)
M			core/backends/devicelinereader.h (6 lines)
M			core/backends/devicelinereader.cpp (6 lines)
M			core/backends/devicelink.h (8 lines)
M			core/backends/lan/landevicelink.h (4 lines)
M			core/backends/lan/landevicelink.cpp (26 lines)
M			core/backends/lan/lanlinkprovider.h (8 lines)
M			core/backends/lan/lanlinkprovider.cpp (90 lines)
M			core/backends/lan/lanpairinghandler.h (4 lines)
M			core/backends/lan/lanpairinghandler.cpp (24 lines)
M			core/backends/lan/socketlinereader.h (6 lines)
M			core/backends/lan/socketlinereader.cpp (6 lines)
M			core/backends/linkprovider.h (4 lines)
M			core/backends/loopback/loopbackdevicelink.h (2 lines)
M			core/backends/loopback/loopbackdevicelink.cpp (8 lines)
M			core/backends/loopback/loopbacklinkprovider.h (2 lines)
M			core/backends/loopback/loopbacklinkprovider.cpp (6 lines)
M			core/backends/pairinghandler.h (4 lines)
M			core/daemon.h (4 lines)
M			core/daemon.cpp (14 lines)
M			core/device.h (12 lines)
M			core/device.cpp (58 lines)
M			core/kdeconnectconfig.cpp (2 lines)
M			core/kdeconnectplugin.h (10 lines)
M			core/kdeconnectplugin.cpp (6 lines)
V			core/{networkpackage.h → networkpacket.h}
V			core/{networkpackage.cpp → networkpacket.cpp}
V			core/{networkpackagetypes.h → networkpackettypes.h}
V			core/{networkpacket.h ← networkpackage.h} (18 lines)
V			core/{networkpacket.cpp ← networkpackage.cpp} (26 lines)
V			core/{networkpackettypes.h ← networkpackagetypes.h} (10 lines)
M			core/pluginloader.cpp (10 lines)
M			interfaces/notificationsmodel.cpp (1 line)
M			plugins/README.txt (10 lines)
M			plugins/battery/batteryplugin.h (4 lines)
M			plugins/battery/batteryplugin.cpp (6 lines)
M			plugins/battery/kdeconnect_battery.json (4 lines)
M			plugins/clipboard/clipboardplugin.h (4 lines)
M			plugins/clipboard/clipboardplugin.cpp (6 lines)
M			plugins/clipboard/kdeconnect_clipboard.json (4 lines)
M			plugins/findmyphone/findmyphoneplugin.h (4 lines)
M			plugins/findmyphone/findmyphoneplugin.cpp (6 lines)
M			plugins/findmyphone/kdeconnect_findmyphone.json (2 lines)
M			plugins/lockdevice/kdeconnect_lockdevice.json (4 lines)
M			plugins/lockdevice/lockdeviceplugin.h (6 lines)
M			plugins/lockdevice/lockdeviceplugin.cpp (14 lines)
M			plugins/mousepad/kdeconnect_mousepad.json (4 lines)
M			plugins/mousepad/mousepadplugin.h (6 lines)
M			plugins/mousepad/mousepadplugin.cpp (10 lines)
M			plugins/mousepad_windows/kdeconnect_mousepad.json (4 lines)
M			plugins/mousepad_windows/mousepadplugin_windows.h (2 lines)
M			plugins/mousepad_windows/mousepadplugin_windows.cpp (2 lines)
M			plugins/mpriscontrol/kdeconnect_mpriscontrol.json (4 lines)
M			plugins/mpriscontrol/mpriscontrolplugin.h (6 lines)
M			plugins/mpriscontrol/mpriscontrolplugin.cpp (24 lines)
M			plugins/mprisremote/kdeconnect_mprisremote.json (4 lines)
M			plugins/mprisremote/mprisremoteplugin.h (6 lines)
M			plugins/mprisremote/mprisremoteplugin.cpp (28 lines)
M			plugins/notifications/kdeconnect_notifications.json (4 lines)
M			plugins/notifications/notification.h (12 lines)
M			plugins/notifications/notification.cpp (14 lines)
M			plugins/notifications/notificationsdbusinterface.h (2 lines)
M			plugins/notifications/notificationsdbusinterface.cpp (10 lines)
M			plugins/notifications/notificationsplugin.h (6 lines)
M			plugins/notifications/notificationsplugin.cpp (8 lines)
M			plugins/pausemusic/kdeconnect_pausemusic.json (2 lines)
M			plugins/pausemusic/pausemusicplugin.h (2 lines)
M			plugins/pausemusic/pausemusicplugin.cpp (2 lines)
M			plugins/ping/kdeconnect_ping.json (4 lines)
M			plugins/ping/pingplugin.h (4 lines)
M			plugins/ping/pingplugin.cpp (10 lines)
M			plugins/remotecommands/kdeconnect_remotecommands.json (4 lines)
M			plugins/remotecommands/remotecommandsplugin.h (2 lines)
M			plugins/remotecommands/remotecommandsplugin.cpp (14 lines)
M			plugins/remotecontrol/kdeconnect_remotecontrol.json (4 lines)
M			plugins/remotecontrol/remotecontrolplugin.h (4 lines)
M			plugins/remotecontrol/remotecontrolplugin.cpp (8 lines)
M			plugins/remotekeyboard/kdeconnect_remotekeyboard.json (4 lines)
M			plugins/remotekeyboard/remotekeyboardplugin.h (8 lines)
M			plugins/remotekeyboard/remotekeyboardplugin.cpp (12 lines)
M			plugins/runcommand/kdeconnect_runcommand.json (4 lines)
M			plugins/runcommand/runcommandplugin.h (2 lines)
M			plugins/runcommand/runcommandplugin.cpp (10 lines)
M			plugins/screensaver-inhibit/screensaverinhibitplugin.h (2 lines)
M			plugins/screensaver-inhibit/screensaverinhibitplugin.cpp (2 lines)
M			plugins/sendnotifications/kdeconnect_sendnotifications.json (4 lines)
M			plugins/sendnotifications/notificationslistener.cpp (4 lines)
M			plugins/sendnotifications/sendnotificationsplugin.h (4 lines)
M			plugins/sendnotifications/sendnotificationsplugin.cpp (2 lines)
M			plugins/sftp/kdeconnect_sftp.json (4 lines)
M			plugins/sftp/mounter.h (2 lines)
M			plugins/sftp/mounter.cpp (8 lines)
M			plugins/sftp/sftpplugin.h (6 lines)
M			plugins/sftp/sftpplugin.cpp (6 lines)
M			plugins/share/kdeconnect_share.json (4 lines)
M			plugins/share/shareplugin.h (4 lines)
M			plugins/share/shareplugin.cpp (18 lines)
M			plugins/telephony/kdeconnect_telephony.json (4 lines)
M			plugins/telephony/telephonyplugin.h (10 lines)
M			plugins/telephony/telephonyplugin.cpp (16 lines)
M			tests/CMakeLists.txt (2 lines)
M			tests/devicetest.cpp (14 lines)
M			tests/lanlinkprovidertest.cpp (66 lines)
V			tests/{networkpackagetests.h → networkpackettests.h}
V			tests/{networkpackagetests.cpp → networkpackettests.cpp}
V			tests/{networkpackettests.h ← networkpackagetests.h} (12 lines)
V			tests/{networkpackettests.cpp ← networkpackagetests.cpp} (38 lines)
M			tests/testnotificationlistener.cpp (166 lines)
M			tests/testsocketlinereader.cpp (20 lines)
M			tests/testsslsocketlinereader.cpp (30 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	28645	d58f6cf		Mar 4 2018, 9:33 PM	★	★
Diff 2	28646	d58f6cf	Missing change	Mar 4 2018, 9:41 PM	★	★
Diff 3	28744	d58f6cf	R224:f47f51782719a763429bbfc746b80b531d1f9093	Mar 5 2018, 7:03 PM	★	★