Differential D11028

[media controller applet] Fix JS error on no xesam:url data set
ClosedPublic
Actions

Authored by kossebau on Mar 4 2018, 6:55 PM.

Details

Reviewers
broulik
Commits
R120:c7f2d8e7331a: [media controller applet] Fix JS error on no xesam:url data set

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Mar 4 2018, 6:55 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 4 2018, 6:55 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kossebau requested review of this revision.Mar 4 2018, 6:55 PM
broulik accepted this revision.Mar 5 2018, 8:25 AM

My approach would have been

var xesamUrl = (metadata["xesam:url"] || "").toString();

but this is fine and more understandable for non-JS developers :)

This revision is now accepted and ready to land.Mar 5 2018, 8:25 AM
kossebau added a comment.Mar 5 2018, 12:41 PM
In D11028#218774, @broulik wrote:

My approach would have been

var xesamUrl = (metadata["xesam:url"] || "").toString();

but this is fine and more understandable for non-JS developers :)

It took me years to no longer be a JS developer ;) But never seen this pattern before, think this is more nice, so will go for that :)

Closed by commit R120:c7f2d8e7331a: [media controller applet] Fix JS error on no xesam:url data set (authored by kossebau). · Explain WhyMar 5 2018, 12:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 28702

View Options

applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

Loading...