Details
Diff Detail
- Repository
- R232 AtCore
- Branch
- injectParser
- Lint
No Linters Available - Unit
No Unit Test Coverage
What's the difference in terms of speed and code from this one or v1? can you choose one to be the true one and discard the other one?
i have not profiled these. i like the string version better because it does not add any new includes and provides the same functionality in a more robust way since its less error prone to pick out a string then look for a command. Again without doing any profiling its just personal preferance for now.
I think that this implementation is much more cleaner
| src/printthread.cpp | ||
|---|---|---|
| 172 | This function should be used ir our default gcode handle also, I would be nice to use it in text gui gcode entry. | |
| 184 | static QCommandLineParser parser;
if(!parser.optionNames()) {
parser.setSingleDashWordOptionMode(QCommandLineParser::ParseAsLongOptions);
parser.addOptions(d->options);
} | |
| 192 | bool wait = !QString::compare(args.at(2).simplified(), QStringLiteral("true"), Qt::CaseInsensitive); ? | |
| 199 | first().toInt() will make it more legible | |
- rebase
- most of patrick's suggestions
| src/printthread.cpp | ||
|---|---|---|
| 199 | I would rather use at() to be consistant. | |
| src/printthread.cpp | ||
|---|---|---|
| 192 | What are you saying does not make sense with the code, shouldn't it be without the ! | |
| src/printthread.cpp | ||
|---|---|---|
| 192 | yea you would think (i thought so too) . then it didn't work and i read the docs... this is why i had == 0 before but, if ! 0 is true and if ! other ints is false so it works. | |