Fix MPRIS pause
ClosedPublic
Actions

Authored by nicolasfella on Mar 4 2018, 3:34 PM.

Details

Reviewers

astippich

Group Reviewers

Elisa

Commits

R255:6e4f63227aff: Fix MPRIS pause

Summary

BUG: 390010

According to the MPRIS spec (https://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html) the value of canPause should not depend on whether the track is currently paused. This patch makes Elisa behave
according to the specification and makes it controllable via KDE Connect

Test Plan

Inspect via DBus Viewer and KDE Connect

Repository

R255 Elisa

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

nicolasfella requested review of this revision.Mar 4 2018, 3:34 PM

nicolasfella created this revision.

Thanks! Coincidentally, I was looking into the same thing today. Reading the specification, this is the correct fix and mine wasn't entirely correct.

Please add the bug to the summary before pushing

BUG: 390010

This revision is now accepted and ready to land.Mar 4 2018, 4:09 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/mpris2/mediaplayer2player.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	28603	58647d0		Mar 4 2018, 3:34 PM	★	★
Diff 2	28607	58647d0	R255:6e4f63227aff718ee38d6d47b4fd9676ff5be756	Mar 4 2018, 4:14 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
771c9ce69911	2dc5f5061566	58647d0da5fd	Nicolas Fella	Fix MPRIS pause (Show More…)	Mar 4 2018, 3:31 PM