If the android code sees a file url, and album art is needed, it will start a request to transfer the album art. This code does some sanity checks to prevent abuse and then transfers the album art.
Details
- Reviewers
nicolasfella albertvaka - Group Reviewers
KDE Connect - Commits
- R224:33c2a100b1cc: Support file url album art - Desktop
Art is transferred succesfully.
Diff Detail
- Repository
- R224 KDE Connect
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
The payloads API seems to be broken and is causing problems in the notifications plugin because we send the notification icons with it (see my email in the kdeconnect mailing list). I think we should make sure it works well before making more plugins use it.
Wasn't that due to transferring the icon twice at the same time? This code shouldn't do that, so that's not really a problem.
Out of scope for this patch, but would it make sense to add KIO support for this? Media files could be on e.g. a samba share, but even then the thumbnails could be elsewhere (like /tmp)
I'm not sure what you mean. It doesn't really matter where the music files are stored, as long as the player puts the thumbnails in a file:// url. Vlc for example puts the thumbnails in the ~/.cache folder. I don't think players should (or do) actually publish smb:// album art urls, since these urls aren't supported everywhere.
I'm talking about supporting other protocols for thumbnail (other than file and https). But you're probably right, most players will use either file or http(s)