Differential D10997

Fix conversion of AccessPoint flags to capabilities
ClosedPublic
Actions

Authored by fvogt on Mar 3 2018, 6:41 PM.

Details

Reviewers
jgrulich
kfunk
Group Reviewers
Frameworks
Commits
R282:641f26a3d48d: Fix conversion of AccessPoint flags to capabilities
Summary

The value of Flags is a set of independant bits, so using a switch-case here
does not work.

For some reason NM 1.10.4 returns 3 as Flags, which makes this return None.

Test Plan

plasma-nm showed "unknown security type" before, now it's "WPA2-PSK" again.

Diff Detail

Repository
R282 NetworkManagerQt
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
fvogt created this revision.Mar 3 2018, 6:41 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 3 2018, 6:41 PM
fvogt requested review of this revision.Mar 3 2018, 6:41 PM
fvogt updated this revision to Diff 28512.

Use camelCase

jgrulich accepted this revision.Mar 5 2018, 6:56 AM
This revision is now accepted and ready to land.Mar 5 2018, 6:56 AM
Closed by commit R282:641f26a3d48d: Fix conversion of AccessPoint flags to capabilities (authored by fvogt). · Explain WhyMar 5 2018, 8:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/accesspoint.cpp (9 lines)

Diff 28676

View Options

src/accesspoint.cpp

Loading...